[webkit-reviews] review granted: [Bug 107905] Quick fix for Chromium EWS bots running out of space due to a tmp file leak : [Attachment 184650] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 107905: Quick fix for Chromium EWS bots running out of space due to a tmp
file leak
https://bugs.webkit.org/show_bug.cgi?id=107905

Attachment 184650: Patch
https://bugs.webkit.org/attachment.cgi?id=184650&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184650&action=review


> Tools/EWSTools/start-queue.sh:47
> +    # This clears any temporary file leaks after running tests.
> +    # Not the nicest solution but it will keep the queues running instead of

> +    # filling up all remaining disk space.
> +    find /tmp/* -delete

This seems quite dangerous...  I could imagine that other long-running process
might want their temp files to not die every 2 hours... :)

But we can also try this and iterate.