[webkit-reviews] review granted: [Bug 107871] Fixing the diff_parser to correctly identify git diffs even with leading comments. : [Attachment 184601] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 107871: Fixing the diff_parser to correctly identify git diffs even with
leading comments.
https://bugs.webkit.org/show_bug.cgi?id=107871

Attachment 184601: Patch
https://bugs.webkit.org/attachment.cgi?id=184601&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184601&action=review


LGTM.

> Tools/Scripts/webkitpy/common/checkout/diff_parser.py:78
>  # FIXME: This method belongs on DiffParser
> -def get_diff_converter(first_diff_line):
> +def get_diff_converter(lines):

Commonly to solve this sort of testing problem, we just make an object, make
this function a method, and then do:

def my_free_function(foo):
     return MyNewObject().my_free_function(foo)

I guess we just haven't gotten to that with DiffParser yet.