[webkit-reviews] review denied: [Bug 107776] [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface : [Attachment 184385] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 107776: [chromium] Provide compositor offscreen context through the
WebLayerTreeViewClient interface
https://bugs.webkit.org/show_bug.cgi?id=107776

Attachment 184385: Patch
https://bugs.webkit.org/attachment.cgi?id=184385&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I'm not really a fan of keeping the GrContext so tightly associated with the
context.  That was a mistake with GraphicsContext3D and it's not going to get
easier to deal with in the future, IMO.  I'd rather do it like this:

1.) Add something like WGC3D::bindGrContext() to associate a GrContext with a
WGC3D
2.) Add ownership of the main-thread GrContext somewhere in WebCore (if it's
still off of GraphicsContext3DPrivate that's OK with me - at least that way it
only impacts WebCore)
3.) Figure out who can own and provide a GrContext for the filter context.  I
think it should be maintained completely outside of WebKit, even if WebKit
still owns+operates the off-thread WGC3D