[webkit-reviews] review granted: [Bug 107854] [WK2][EFL] PagePolicyClientEfl should be based on C WK2 API : [Attachment 184567] patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 107854: [WK2][EFL] PagePolicyClientEfl should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107854

Attachment 184567: patch
https://bugs.webkit.org/attachment.cgi?id=184567&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184567&action=review


> Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.cpp:94
> +    bool isXMLType =
WKStringIsEqualToUTF8CStringIgnoringCase(mimeType.get(), "text/xml") ||
WKStringIsEqualToUTF8CStringIgnoringCase(mimeType.get(), "application/xml");

Using the "IgnoringCase" here seems unnecessary. If ResourceResponse starts
returning uppercase mimetype, it would break WebCore.