[webkit-reviews] review granted: [Bug 96272] NPN_InitializeVariantWithStringCopy is wrong for platforms that return NULL from malloc(0) : [Attachment 184453] NPN_InitializeVariantWithStringCopy patch (3)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Brianceau
<jbrianceau at nds.com>'s request for review:
Bug 96272: NPN_InitializeVariantWithStringCopy is wrong for platforms that
return NULL from malloc(0)
https://bugs.webkit.org/show_bug.cgi?id=96272

Attachment 184453: NPN_InitializeVariantWithStringCopy patch (3)
https://bugs.webkit.org/attachment.cgi?id=184453&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184453&action=review


> Source/WebCore/ChangeLog:10
> +	   No new tests. This is platform dependant.

Spelling error: dependent is not spelled with an "a"

> Source/WebCore/bridge/npruntime.cpp:90
> +	   // switching to fastMalloc would be better to avoid length check but
this is not desirable
> +	   // as NPN_MemAlloc is using malloc and there might be plugins that
mix NPN_MemAlloc and malloc too

WebKit comment coding style is “sentence style”. First letter capitalized,
period at end of sentence.