[webkit-reviews] review denied: [Bug 107804] [mac] ImageBuffer should create accelerated buffers for small canvases, but we shouldn't force them to create compositing layers : [Attachment 184441] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 107804: [mac] ImageBuffer should create accelerated buffers for small
canvases, but we shouldn't force them to create compositing layers
https://bugs.webkit.org/show_bug.cgi?id=107804

Attachment 184441: patch
https://bugs.webkit.org/attachment.cgi?id=184441&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184441&action=review


>> Source/WebCore/rendering/RenderLayerCompositor.cpp:1907
>> +	    return canvas->renderingContext() &&
canvas->renderingContext()->isAccelerated() && (canvas->size().area() >
canvasAreaThresholdRequiringCompositing);
> 
> This is shared code, I wonder if this is reasonable for everyone...

We should probably #ifdef it. Maybe USE_COMPOSITING_FOR_SMALL_CANVASES or
something, disabled for PLATFORM(MAC) and PLATFORM(IOS).