[webkit-reviews] review denied: [Bug 107814] Web Inspector: implement search for workspace sources : [Attachment 184495] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 107814: Web Inspector: implement search for workspace sources
https://bugs.webkit.org/show_bug.cgi?id=107814

Attachment 184495: Patch
https://bugs.webkit.org/attachment.cgi?id=184495&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184495&action=review


> Source/WebCore/inspector/front-end/ContentProviders.js:291
>	       callback(result);

no need for intermediate result variable.

> Source/WebCore/inspector/front-end/utilities.js:646
> +function performSearchInContent(content, query, caseSensitive, isRegex)

utilities are non-WebInspector aware. This should be defined next to
WebInspector.ContentProvider.SearchMatch.