[webkit-reviews] review granted: [Bug 107694] [Qt][WK1] Remember denied permission for notifications : [Attachment 184236] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 24 06:20:44 PST 2013
Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 107694: [Qt][WK1] Remember denied permission for notifications
https://bugs.webkit.org/show_bug.cgi?id=107694
Attachment 184236: Patch
https://bugs.webkit.org/attachment.cgi?id=184236&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review
>> Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424
>> +
callback->handleEvent(Notification::permissionString(permission));
>
> Is this a patch split artifact?
Looks good to me otherwise, please remove this before landing.
More information about the webkit-reviews
mailing list