[webkit-reviews] review denied: [Bug 107814] Web Inspector: implement search for workspace sources : [Attachment 184472] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 107814: Web Inspector: implement search for workspace sources
https://bugs.webkit.org/show_bug.cgi?id=107814

Attachment 184472: Patch
https://bugs.webkit.org/attachment.cgi?id=184472&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184472&action=review


> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:96
> +	   function contentCallback(content, base64Encoded, mimeType)

Please annotate.

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:99
> +	       var lines = content.split("\n");

You either need lines or lineEndings.

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:102
> +	       for (var i = 0; i < lines.length; ++i) {

Please extract this code.