[webkit-reviews] review denied: [Bug 107704] Web Inspector: MIME type errors should be "debug" level. : [Attachment 184261] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 107704: Web Inspector: MIME type errors should be "debug" level.
https://bugs.webkit.org/show_bug.cgi?id=107704

Attachment 184261: Patch
https://bugs.webkit.org/attachment.cgi?id=184261&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184261&action=review


> Source/WebCore/inspector/front-end/NetworkManager.js:185
> +		   WebInspector.ConsoleMessage.MessageLevel.Debug,

I think that this is still a warning. It should be filtered out by source, not
severity. Like I know how console.warn, console.error and console.log are
processed. I can stick to some standard in my code and tune my filters
accordingly. But I don't know what severity is set for the internal messages.
My guess would be that they match the common sense:
- warnings warn about errors browser could recover from
- errors report problems browser could not recover from
- debug generates verbose debugging info flow
- I would not expect browser to generate Log level messages to me.

I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in
console that would filter by source (in addition to existing message level).