[webkit-reviews] review granted: [Bug 107805] Web Inspector: [Canvas] REGRESSION: stack traces in the replay log are gone : [Attachment 184455] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107805: Web Inspector: [Canvas] REGRESSION: stack traces in the replay log
are gone
https://bugs.webkit.org/show_bug.cgi?id=107805

Attachment 184455: Patch
https://bugs.webkit.org/attachment.cgi?id=184455&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184455&action=review


>>> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:236
>>> +	 Error.prepareStackTrace = function(error, structuredStackTrace)
>> 
>> Error is a part of the page's context. Why do you need to intercept it?
> 
> The canvas calls are also made from the page's context. We want the stack
trace of those calls. To get it, we use V8's
http://code.google.com/p/v8/wiki/JavaScriptStackTraceApi, namely
Error.prepareStackTrace method.

We should not modify user functions if at all possible. Can we use a binding
for this?