[webkit-reviews] review denied: [Bug 107779] Split CSSOMWrapper data and functions out from StyleResolver into its own class : [Attachment 184407] factor CSSOMWrapper logic into a CSSOMWrapper

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 107779: Split CSSOMWrapper data and functions out from StyleResolver into
its own class
https://bugs.webkit.org/show_bug.cgi?id=107779

Attachment 184407: factor CSSOMWrapper logic into a CSSOMWrapper
https://bugs.webkit.org/attachment.cgi?id=184407&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184407&action=review


Why should this be in a separate class? What is the purpose of this change?
CSSOMWrapper is a bad name for this class, as we already have CSSOM wrappers in
WebKit, and this class has very little to do with them.

> Source/WebCore/css/StyleResolver.cpp:296
> +    , m_cssomWrapper()

This line is not needed.

> Source/WebCore/css/StyleResolver.h:455
> +    CSSOMWrapper& cssomWrapepr() { return m_cssomWrapper; }

This name is wrong.