[webkit-reviews] review denied: [Bug 107793] Web Inspector: Add explanation for Console object expansion behaviour : [Attachment 184419] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 107793: Web Inspector: Add explanation for Console object expansion
behaviour
https://bugs.webkit.org/show_bug.cgi?id=107793

Attachment 184419: Patch
https://bugs.webkit.org/attachment.cgi?id=184419&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184419&action=review


> Source/WebCore/inspector/front-end/ConsoleMessage.js:308
> +	   var note = section.element.querySelector(".header >
.title").createChild("span", "object-info-state-note");

You should not reach out for ObjectPropertiesSection internals from here - it
is better to have this code in the object properties section itself. You can
add ObjectPropertiesSection.prototype.showExpansionHint(enabled) to control it
from here, default it to false.

> Source/WebCore/inspector/front-end/inspector.css:1216
> +    display: none;

We try to be minimalistic wrt styles - sounds like alignment ones are not
needed here.

> Source/WebCore/inspector/front-end/inspector.css:1224
> +    font-size: 10px;

We typically inherit font proeprties.