[webkit-reviews] review granted: [Bug 107799] Web Inspector: breakpoints are not restored upon reload for scripts with script mapping. : [Attachment 184432] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 01:01:41 PST 2013


Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 107799: Web Inspector: breakpoints are not restored upon reload for scripts
with script mapping.
https://bugs.webkit.org/show_bug.cgi?id=107799

Attachment 184432: Patch
https://bugs.webkit.org/attachment.cgi?id=184432&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:116
> +	   var uiSourceCode = /** @type {WebInspector.UISourceCode} */
(event.target);

Can this fire several times per the same UISourceCode? I'm wary of duplicate
breakpoints, actually.


More information about the webkit-reviews mailing list