[webkit-reviews] review granted: [Bug 107786] Switch sandbox initialization back to being at initialization message time (for now) : [Attachment 184401] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 107786: Switch sandbox initialization back to being at initialization
message time (for now)
https://bugs.webkit.org/show_bug.cgi?id=107786

Attachment 184401: Patch
https://bugs.webkit.org/attachment.cgi?id=184401&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184401&action=review


This patch is a bit incomplete, we should delete extension handle members from
WebProcessCreationParameters, and stop creating them in
WebContext::createNewWebProcess().

> Source/WebKit2/Shared/SandboxInitializationParameters.h:52
> +    enum Mode {

Maybe ProfileSelectionMode?

> Source/WebKit2/WebProcess/WebProcess.cpp:250
> +    platformInitializeSandboxInitializationParameters(parameters,
sandboxParameters);

That's a mouthful!

> Source/WebKit2/WebProcess/WebProcess.cpp:251
> +    initializeSandbox(sandboxParameters);

I'm not a fan of processes needing to call initializeSandbox() explicitly.
Today, most of them are either not sandboxed or using custom code, but the goal
is that they are all sandboxed via ChildProcess code.

Not a big deal, but adds a bit more copy/pasting.