[webkit-reviews] review granted: [Bug 107630] Implement MouseEvent constructor : [Attachment 184367] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 107630: Implement MouseEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=107630

Attachment 184367: Patch
https://bugs.webkit.org/attachment.cgi?id=184367&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184367&action=review


> Source/WebCore/bindings/scripts/CodeGenerator.pm:735
> +# FIXME: Rename to IsInheritInterface

IsInheritedInterface ?	I guess we can work out the proper name when we do the
renaming.

> Source/WebCore/bindings/scripts/CodeGenerator.pm:755
> +sub IsInheritExtendedAttribute

IsInheritedExtendedAttribute ?	DoesInheritExtendedAttribute? 
InheritsExtendedAttribute ?

> Source/WebCore/bindings/v8/Dictionary.cpp:470
> +	   fprintf(stderr, "V8DOMWrapper::isDOMWrapper(v8Value)\n");

We should probably remove this line before landing.