[webkit-reviews] review granted: [Bug 107762] HTMLDocumentParser should hold the HTMLToken using an OwnPtr : [Attachment 184358] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 107762: HTMLDocumentParser should hold the HTMLToken using an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=107762

Attachment 184358: Patch
https://bugs.webkit.org/attachment.cgi?id=184358&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184358&action=review


This ends up being one more malloc for innerHTML.  I'm not sure if we'll end up
noticing for perf or not.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:341
>	   if (!isParsingFragment())

We could just grab a const reference to the token at the top of this loop.  The
token being able to change is a background-parser thing.

in your setToken() method that you write you should probably ASSERT that we're
not in the middle of a parsing session.