[webkit-reviews] review granted: [Bug 106856] Support variables inside -webkit-box-reflect CSS property. : [Attachment 182872] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 106856: Support variables inside -webkit-box-reflect CSS property.
https://bugs.webkit.org/show_bug.cgi?id=106856

Attachment 182872: Patch
https://bugs.webkit.org/attachment.cgi?id=182872&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182872&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:612
> +    default:
> +	   ASSERT_NOT_REACHED();

Remove the default: case so the compiler will ensure we're testing all cases.

> Source/WebCore/css/CSSReflectValue.cpp:41
> +    if (m_mask)
> +	   return m_direction->cssText() + ' ' + m_offset->cssText() + ' ' +
m_mask->cssText();
> +    return m_direction->cssText() + ' ' + m_offset->cssText();

I would mention in the ChangeLog that you no longer use StringBuilder but this
is just as fast because of StringOperators.h and StringConcatenate.h.

> Source/WebCore/css/CSSReflectValue.cpp:49
> +	   return m_direction->customSerializeResolvingVariables(variables) + '
' + m_offset->customSerializeResolvingVariables(variables) + ' ' +
m_mask->serializeResolvingVariables(variables);
> +    return m_direction->customSerializeResolvingVariables(variables) + ' ' +
m_offset->customSerializeResolvingVariables(variables);

You could mention this in the ChangeLog too.