[webkit-reviews] review requested: [Bug 107426] [CoordinatedGraphics] CSS sticky elements are blinking while scrolling : [Attachment 183988] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has asked  for review:
Bug 107426: [CoordinatedGraphics] CSS sticky elements are blinking while
scrolling
https://bugs.webkit.org/show_bug.cgi?id=107426

Attachment 183988: patch
https://bugs.webkit.org/attachment.cgi?id=183988&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183988&action=review


OK, but I have some questions.
How does this work while you scroll? Does the position change?

> Source/WebKit2/ChangeLog:9
> +	   Set scroll position delta for sticky elements if the they are
> +	   located out of their in-flow layout position (when they have
actually stuck). 

Please add

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:478
> +    if (renderer->isInFlowPositioned() && position == StickyPosition) { //
Sticky element

The comment is unnecessary.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:479
> +	   // Set FixedToViewport 'true' if sticky element is out of its
in-flow position; set 'false' otherwise.

Comment doesn't add any information :)