[webkit-reviews] review granted: [Bug 107693] [WK2][EFL] Remove unneeded private methods : [Attachment 184234] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 107693: [WK2][EFL] Remove unneeded private methods
https://bugs.webkit.org/show_bug.cgi?id=107693

Attachment 184234: Patch
https://bugs.webkit.org/attachment.cgi?id=184234&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review


> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:380
> +    if (m_pendingSurfaceResize || !m_evasGLSurface) {

The way the state is handled before coming here is madness.

I am not sure you even need "|| !m_evasGLSurface". I think some clarifying of
the state would be beneficial.