[webkit-reviews] review granted: [Bug 107717] Assert that Supplementable objects is only used in their creator thread : [Attachment 184282] The patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 13:14:14 PST 2013


Adam Barth <abarth at webkit.org> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 107717: Assert that Supplementable objects is only used in their creator
thread
https://bugs.webkit.org/show_bug.cgi?id=107717

Attachment 184282: The patch.
https://bugs.webkit.org/attachment.cgi?id=184282&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184282&action=review


> Source/WebCore/platform/Supplementable.h:128
> +    ThreadIdentifier m_threadId;

I wonder if this is the right thing for code that uses libdispatch.  I think
there's some other notion of thread affinity that we're supposed to use in
those cases.


More information about the webkit-reviews mailing list