[webkit-reviews] review requested: [Bug 106815] [Chromium] Tests for spell checker behavior : [Attachment 184278] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 12:10:19 PST 2013


Rouslan Solomakhin <rouslan+webkit at chromium.org> has asked  for review:
Bug 106815: [Chromium] Tests for spell checker behavior
https://bugs.webkit.org/show_bug.cgi?id=106815

Attachment 184278: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=184278&action=review

------- Additional Comments from Rouslan Solomakhin
<rouslan+webkit at chromium.org>
Please review the attached patch. Here is the behavior for Chromium that this
patch sets:

- Chrome selects the misspelled word on context click. 
- Spelling should work when the user selects the misspelled word exactly. 
- If the word is not misspelled, there should be no spelling options in the
context menu. 
- Chrome should select multi-word misspellings on context click. 
- Spelling should work when the user selects a multi-word misspelling exactly. 

- Spelling should work for double-clicked misspellings. 
- Spelling should ignore whitespace. 
- Underscores should be treated as whitespace: spelling should ignore them. 
- Punctuation marks should be treated as whitespace: spelling should ignore
them. 
- Spelling should be disabled when user selects a part of misspelling. 
- Spelling should be disabled when user selects multiple words that are not a
single misspelling.


More information about the webkit-reviews mailing list