[webkit-reviews] review denied: [Bug 40300] Web Inspector: [JSC] implement script source editing : [Attachment 155472] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 23 12:03:24 PST 2013
Oliver Hunt <oliver at apple.com> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 40300: Web Inspector: [JSC] implement script source editing
https://bugs.webkit.org/show_bug.cgi?id=40300
Attachment 155472: Patch
https://bugs.webkit.org/attachment.cgi?id=155472&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155472&action=review
I've redone how compilation works since this patch was put up so a lot of the
refactoring can probably go away :-/
> Source/JavaScriptCore/interpreter/Interpreter.cpp:1131
> - if (i == 0) {
> + if (!i) {
Don't change this, while it's a style violation we don't really like changes
just to appease the style bot.
More information about the webkit-reviews
mailing list