[webkit-reviews] review granted: [Bug 106988] Get WebCore compiling in VS2010 (32 bit) : [Attachment 183642] WebCore property sheets, project files and modified buildscripts

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 106988: Get WebCore compiling in VS2010 (32 bit)
https://bugs.webkit.org/show_bug.cgi?id=106988

Attachment 183642: WebCore property sheets, project files and modified
buildscripts
https://bugs.webkit.org/attachment.cgi?id=183642&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review


rs=me.	I do think it would be better to use "WebCore.vcxproj" as the directory
name.

> ChangeLog:8
> +	   * ForwardingHeaders/wtf: Removed.

Did you actually remove ForwardingHeaders subdirectories? Why?	The patch
doesn't seem to do anything to these guys.

> ChangeLog:15
> +	   * WebCore.vcproj/WebCore.sln:

How about putting this solution file in WebCore.vcxproj, so that it does not
clobber the VS2005 version?

> ChangeLog:16
> +	   * WebCore2010.vcproj: Added.

How about WebCore.vcxproj instead of WebCore2010?