[webkit-reviews] review granted: [Bug 106949] Build Apple Windows 7 port in VS2010 in 32 and 64 bit : [Attachment 184093] WebKit Solution file

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 106949: Build Apple Windows 7 port in VS2010 in 32 and 64 bit
https://bugs.webkit.org/show_bug.cgi?id=106949

Attachment 184093: WebKit Solution file
https://bugs.webkit.org/attachment.cgi?id=184093&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184093&action=review


Looks good.  I think the ChangeLog comments are out-of-sync with the actual
directory name you used.  Please correct when landing.

r=me.

> ChangeLog:9
> +	   * WebKit2010.vcproj: Added.

WebKit2010.vcxproj added?  :-)

> ChangeLog:10
> +	   * WebKit2010.vcproj/WebKit2010.sln: Added.

Ditto.

> WebKit.vcxproj/WebKit2010.sln:1
> +

I don't think you need to 2010 on the solution file.  It's in its own
WebKit.vcxproj directory, so will not conflict with the VS2005 version.