[webkit-reviews] review granted: [Bug 107604] [CSS Grid Layout] Add support for max-content : [Attachment 184095] Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 107604: [CSS Grid Layout] Add support for max-content
https://bugs.webkit.org/show_bug.cgi?id=107604

Attachment 184095: Proposed change 1: Merrily add the missing steps from the
spec, no code sharing for now.
https://bugs.webkit.org/attachment.cgi?id=184095&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184095&action=review


>
LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:10
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

>
LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:17
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:10
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:17
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:32
> +    background-color: blue;
> +    -webkit-grid-column: 1;
> +    -webkit-grid-row: 1;

This seems redundant with the code in grid.css.