[webkit-reviews] review denied: [Bug 107607] [Chromium, Mobile] Do not show disambiguation pop up in mobile sites : [Attachment 184097] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied dfalcantara at chromium.org's request
for review:
Bug 107607: [Chromium, Mobile] Do not show disambiguation pop up in mobile
sites
https://bugs.webkit.org/show_bug.cgi?id=107607

Attachment 184097: Patch
https://bugs.webkit.org/attachment.cgi?id=184097&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184097&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:758
> +	   // Don't trigger a disambiguation popup on sites designed for mobile
devices.
> +	   // Instead, assume that the page has been designed with big enough
buttons and links.
> +	   ViewportArguments viewportArguments =
mainFrameImpl()->frame()->document()->viewportArguments();
> +	   bool isLikelyMobileSite = !viewportArguments.userZoom ||
(viewportArguments.width == ViewportArguments::ValueDeviceWidth);

Do we have other heuristics like this elsewhere?  Should we use the same one
consistently?  If not, should we factor this code in a way that future code
that wants a "is mobile site" heuristic can use it too?

Also, we need a test.