[webkit-reviews] review denied: [Bug 107680] [EFL][WK2] Use C API inside ewk_favicon_database : [Attachment 184216] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 11:05:09 PST 2013


Brady Eidson <beidson at apple.com> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 107680: [EFL][WK2] Use C API inside ewk_favicon_database
https://bugs.webkit.org/show_bug.cgi?id=107680

Attachment 184216: Patch
https://bugs.webkit.org/attachment.cgi?id=184216&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184216&action=review


>> Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:77
>> +   
toImpl(iconDatabaseRef)->synchronousIconURLForPageURL(toWTFString(pageURL),
iconURL);
> 
> I don't know if this should be exposed via an API.

It should not be.  Can you explain more why you need it?

> Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:85
> +bool WKIconDatabaseIsURLImportCompleted(WKIconDatabaseRef iconDatabaseRef)
> +{
> +    return toImpl(iconDatabaseRef)->isUrlImportCompleted();
> +}

The "url import" is an *extremely* fragile implementation detail of the icon
database and has no business being exposed as API.

Could you share details why you think you need it?


More information about the webkit-reviews mailing list