[webkit-reviews] review requested: [Bug 83869] [Gtk] HTML5 Media controls require a design refresh : [Attachment 184253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 09:37:30 PST 2013


Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 83869: [Gtk] HTML5 Media controls require a design refresh
https://bugs.webkit.org/show_bug.cgi?id=83869

Attachment 184253: Patch
https://bugs.webkit.org/attachment.cgi?id=184253&action=review

------- Additional Comments from Xabier Rodríguez Calvar <calvaris at igalia.com>
I reworked a bit the margins to make them more similar, even when some buttons
disappear.

I created rebaselines for some tests and marked some others in the
TestExpectations because they do not work in Chromium. I would create a bug and
put it in the patch if the rest of the review is ok.

Martin, would you be so kind of reviewing the patch? If it is ok, we could
create the bug for the new expectations and land it manually tomorrow as we
need some actions done in the bots.


More information about the webkit-reviews mailing list