[webkit-reviews] review granted: [Bug 106908] [GTK] Click on an anchor link makes page title dissappear : [Attachment 184239] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 106908: [GTK] Click on an anchor link makes page title dissappear
https://bugs.webkit.org/show_bug.cgi?id=106908

Attachment 184239: Patch
https://bugs.webkit.org/attachment.cgi?id=184239&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Okay. Looks good. Did you run the unit tests? In the future you probably want
to avoid the usage of booleans [1], but for this change it's probably okay.

1. See the WebKit style guide where it says: "Prefer enums to bools on function
parameters if callers are likely to be passing constants, since named constants
are easier to read at the call site. An exception to this rule is a setter
function, where the name of the function already makes clear what the boolean
is."