[webkit-reviews] review granted: [Bug 106549] [CSS Filters] Filter blur effects don't transition outside of box : [Attachment 184038] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 23 07:59:39 PST 2013
Dirk Schulze <krit at webkit.org> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 106549: [CSS Filters] Filter blur effects don't transition outside of box
https://bugs.webkit.org/show_bug.cgi?id=106549
Attachment 184038: Patch
https://bugs.webkit.org/attachment.cgi?id=184038&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184038&action=review
Patch looks great. Just a snippet. r=me with a change request.
> Source/WebCore/rendering/RenderLayer.cpp:1344
> +void RenderLayer::expandRectForFilterOutsets(LayoutRect& rect) const
Can you make this function inline and pass the renderer as well? Add an assert
for the passed renderer, just in case :).
More information about the webkit-reviews
mailing list