[webkit-reviews] review denied: [Bug 107688] Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames : [Attachment 184227] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 07:56:20 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107688: Web Inspector: [Canvas] UI: add a selector to capture a single
canvas frame vs consecutive frames
https://bugs.webkit.org/show_bug.cgi?id=107688

Attachment 184227: Patch
https://bugs.webkit.org/attachment.cgi?id=184227&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review


>>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
>>> +		 setTimeout(this._requestTraceLog.bind(this), 500);
>> 
>> why 500?
> 
> just a number :) any concerns/ideas?

Why do you have this delay? Why do you use magic numbers?


More information about the webkit-reviews mailing list