[webkit-reviews] review denied: [Bug 107648] Web Inspector: allow user to resize inspector window by dragging the toolbar : [Attachment 184189] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 107648: Web Inspector: allow user to resize inspector window by dragging
the toolbar
https://bugs.webkit.org/show_bug.cgi?id=107648

Attachment 184189: Patch
https://bugs.webkit.org/attachment.cgi?id=184189&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184189&action=review


A couple of nits and it is good to land.

> Source/WebCore/inspector/front-end/DockController.js:97
> +    isDockedToBottom: function() {

{ should be on the next line

> Source/WebCore/inspector/front-end/DockController.js:-125
> -	       WebInspector.toolbar.setDockedToBottom(this._dockSide ===
WebInspector.DockController.State.DockedToBottom);

I like reversing this dependency.

> Source/WebCore/inspector/front-end/Toolbar.js:124
> +	   this.element.lastHeight = window.innerHeight;

Why storing this property on element? Store it on this with private field.