[webkit-reviews] review granted: [Bug 107646] REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big : [Attachment 184175] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 107646: REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big
https://bugs.webkit.org/show_bug.cgi?id=107646

Attachment 184175: Patch
https://bugs.webkit.org/attachment.cgi?id=184175&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184175&action=review


Thanks

> Source/WebCore/ChangeLog:9
> +	   g_input_stream_read_async() to workaround a glib buffer. The former

I guess you mean to workaround a glib bug? Assuming skip is more efficient than
read, I think we could add a FIXME pointing to the glib bug to use skip again
once the glib bug is fixed.