[webkit-reviews] review granted: [Bug 107636] [V8] Make an Isolate parameter mandatory in throwError() : [Attachment 184157] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 107636: [V8] Make an Isolate parameter mandatory in throwError()
https://bugs.webkit.org/show_bug.cgi?id=107636

Attachment 184157: Patch
https://bugs.webkit.org/attachment.cgi?id=184157&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review


> Source/WebCore/bindings/v8/WorkerScriptController.cpp:174
> -	       state->exception = throwError(v8GeneralError,
state->errorMessage.utf8().data());
> +	       state->exception = throwError(v8GeneralError,
state->errorMessage.utf8().data(), m_context.get()->GetIsolate());

You shouldn't need to call get().  We've overloaded operator->