[webkit-reviews] review granted: [Bug 74358] prepare-Changelog should support updating the list of changed files : [Attachment 184147] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Timothy Loh <timloh at chromium.org>'s
request for review:
Bug 74358: prepare-Changelog should support updating the list of changed files
https://bugs.webkit.org/show_bug.cgi?id=74358

Attachment 184147: Patch
https://bugs.webkit.org/attachment.cgi?id=184147&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184147&action=review


OK.

> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:31
> +import codecs
>  import logging
> +import os

codecs and os imports are always "bad signs" that code is un-mockable. :)

> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:33
>  import sys

So is sys!  Clearly this file pre-dates our good FileSystem/Executive mocks.