[webkit-reviews] review granted: [Bug 105607] Use Python 2.7 unittest syntax in our unittests : [Attachment 184143] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 105607: Use Python 2.7 unittest syntax in our unittests
https://bugs.webkit.org/show_bug.cgi?id=105607

Attachment 184143: Patch
https://bugs.webkit.org/attachment.cgi?id=184143&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184143&action=review


Fantastic!  Thank you very much!

> Tools/Scripts/webkitpy/common/system/executive_unittest.py:38
>  # Since we execute this script directly as part of the unit tests, we need
to ensure
>  # that Tools/Scripts is in sys.path for the next imports to work correctly.

Huh?  Really?  Oh, I guess it execs itself.  We could totally have a separate
simpler script. :p