[webkit-reviews] review granted: [Bug 107628] Sometimes scroll position is jerky during rubber-band, affects nytimes.com : [Attachment 184140] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 107628: Sometimes scroll position is jerky during rubber-band, affects
nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=107628

Attachment 184140: Patch
https://bugs.webkit.org/attachment.cgi?id=184140&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184140&action=review


> Source/WebCore/page/FrameView.cpp:1929
> +    if (Page* page = m_frame->page()) {
> +	   if (ScrollingCoordinator* scrollingCoordinator =
page->scrollingCoordinator()) {
> +	       if
(!scrollingCoordinator->shouldUpdateScrollLayerPositionOnMainThread())
> +		   return scrollingCoordinator->isRubberBandInProgress();
> +	   }
> +    }
> +#endif
> +
> +    // If the main thread updates the scroll position for this FrameView, we
should return
> +    // ScrollAnimator::isRubberBandInProgress().
> +    if (ScrollAnimator* scrollAnimator = existingScrollAnimator())
> +	   return scrollAnimator->isRubberBandInProgress();

It's a shame that the ScrollingCoordinator and ScrollAnimator don't know about
eachother, otherwise you could just ask one of them for the answer. It's pretty
unwieldy to have to add code like this in several places.