[webkit-reviews] review denied: [Bug 106726] 20% regression on dom_perf/DomDivWalk : [Attachment 184130] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 106726: 20% regression on dom_perf/DomDivWalk
https://bugs.webkit.org/show_bug.cgi?id=106726

Attachment 184130: Patch
https://bugs.webkit.org/attachment.cgi?id=184130&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184130&action=review


> Source/WebCore/dom/Node.cpp:-2623
> -#if ENABLE(DIALOG_ELEMENT)

we don't need this. Instead of that....

> Source/WebCore/dom/Node.h:694
> +    void setIsInTopLayer(bool);

The disabled case could be inlined here.
I think guarding whole definition(s) would be cleaner than having the ifdef in
the function body.