[webkit-reviews] review granted: [Bug 107478] Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries : [Attachment 184053] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Timothy Loh <timloh at chromium.org>'s
request for review:
Bug 107478: Add functions to ChangeLog - parse bug desc/changed functions,
delete/prepend entries
https://bugs.webkit.org/show_bug.cgi?id=107478

Attachment 184053: Patch
https://bugs.webkit.org/attachment.cgi?id=184053&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184053&action=review


>>> Tools/Scripts/webkitpy/common/checkout/changelog.py:450
>>> +	     codecs.open(self.path, "w", "utf-8").write(text + data)
>> 
>> Shouldn't we be using a FileSystem for this?  I'm sorry I didn't catch this
before.  I guess ChangeLog doesn't correctly sit on top of our FileSystem
abstraction anyway?
> 
> ChangeLog uses the fileinput module (i.e. the real filesystem) throughout, so
I thought it would be a bit inconsistent to add functions which use the
FileSystem abstraction. Probably using FileSystem would be better though, so
I'll see if getting rid of fileinput isn't too messy.

I agree.  This doesn't make ChangeLog any worse than it already is (in terms of
mockability).  We can make ChagneLog FileSystem-compatible later in another
bug.