[webkit-reviews] review granted: [Bug 107596] Fix assertions in make8BitFrom16BitSource() with threaded parser : [Attachment 184062] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 107596: Fix assertions in make8BitFrom16BitSource() with threaded parser
https://bugs.webkit.org/show_bug.cgi?id=107596

Attachment 184062: Patch
https://bugs.webkit.org/attachment.cgi?id=184062&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review


> Source/WebCore/html/parser/HTMLToken.h:245
>	       m_externalCharacters = token.data().characters();
>	       m_externalCharactersLength = token.data().length();
> +	       m_isAll8BitData = token.isAll8BitData();

This change is fine, but I think we'll need to rethink this "external
characters" design as part of this work.