[webkit-reviews] review granted: [Bug 107478] Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries : [Attachment 183851] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Timothy Loh <timloh at chromium.org>'s
request for review:
Bug 107478: Add functions to ChangeLog - parse bug desc/changed functions,
delete/prepend entries
https://bugs.webkit.org/show_bug.cgi?id=107478

Attachment 183851: Patch
https://bugs.webkit.org/attachment.cgi?id=183851&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183851&action=review


Aside from the self/cls confusion (which I likely lead you to), this looks
fine.  You'll need to post the final patch with 'cls' replacing 'self' where
necessary.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:114
> +    def _parse_reviewer_text(self, text):

This is called "cls" when it's a class method.