[webkit-reviews] review denied: [Bug 107044] [CSS Grid Layout] Add grid.css to hold the common grid testing code : [Attachment 184037] Proposed change 2: Updated the class names per Tony's request.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 13:46:41 PST 2013


Tony Chang <tony at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 107044: [CSS Grid Layout] Add grid.css to hold the common grid testing code
https://bugs.webkit.org/show_bug.cgi?id=107044

Attachment 184037: Proposed change 2: Updated the class names per Tony's
request.
https://bugs.webkit.org/attachment.cgi?id=184037&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184037&action=review


> LayoutTests/fast/css-grid-layout/resources/grid.css:11
> +#firstRowFirstColumn {

These should be class names, no? You have test cases that have multiple divs
with the same id, which is confusing.


More information about the webkit-reviews mailing list