[webkit-reviews] review granted: [Bug 107319] Allow construction of unprefixed transition DOM events. : [Attachment 183822] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Alexis Menard (darktears)
<alexis at webkit.org>'s request for review:
Bug 107319: Allow construction of unprefixed transition DOM events.
https://bugs.webkit.org/show_bug.cgi?id=107319

Attachment 183822: Patch
https://bugs.webkit.org/attachment.cgi?id=183822&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183822&action=review


> Source/WebCore/ChangeLog:20
> +	   Make possible to construct unprefixed DOM events for transitions.
> +	   Unfortunately I have to duplicate the C++ implementation class of
the
> +	   events (TransitionEvent.h and TransitionEvent.cpp). I can't find a
> +	   better way to re-use the WebKitTransitionEvent class to back the
> +	   TransitionEvent.idl as our code generators don't allow to have a
> +	   different name for the C++ class used in the generated file than the

> +	   interface name specified in the IDL file. Unfortunately
> +	   https://trac.webkit.org/wiki/WebKitIDL#InterfaceName doesn't help as

> +	   it's only a way to unlink the interface name specified in the IDL
with
> +	   the one exposed in JavaScript. I don't think we should support such
a
> +	   feature in our code generators as WebKitTransitionEvent class and
more
> +	   exactly prefixed DOM events for transitions will be removed one day
so
> +	   this use case will become obselete.

I wonder if we should put a big message in the unprefixed implementation making
it clear that any change should be done in both places (as unlikely as this
is).