[webkit-reviews] review denied: [Bug 107535] Change the Supplementable class to not use AtomicString : [Attachment 183966] svn up'ed prelim patch for bot testing.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 107535: Change the Supplementable class to not use AtomicString
https://bugs.webkit.org/show_bug.cgi?id=107535

Attachment 183966: svn up'ed prelim patch for bot testing.
https://bugs.webkit.org/attachment.cgi?id=183966&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183966&action=review


> Source/WTF/wtf/text/LiteralCString.h:94
> +    if (m_hash && m_hash == other.m_hash)
> +	   return true;

Hashes are not guaranteed unique. It's OK to say that, if hashes don't match,
strings don't match, but it's not OK to say that, if hashes do match, string do
match.