[webkit-reviews] review granted: [Bug 107569] BackgroundHTMLParser should simulate tree building in a separate function : [Attachment 184017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 10:57:41 PST 2013


Tony Gentilcore <tonyg at chromium.org> has granted  review:
Bug 107569: BackgroundHTMLParser should simulate tree building in a separate
function
https://bugs.webkit.org/show_bug.cgi?id=107569

Attachment 184017: Patch
https://bugs.webkit.org/attachment.cgi?id=184017&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184017&action=review


> Source/WebCore/html/parser/BackgroundHTMLParser.cpp:129
> +	   // FIXME: This is just a copy of Tokenizer::updateStateFor which
doesn't use HTMLNames.

This isn't exactly true any more. I'd change it to something like:

// FIXME: This is just a copy of Tokenizer::updateStateFor which uses
threadSafeMatches.


More information about the webkit-reviews mailing list