[webkit-reviews] review granted: [Bug 107562] REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions(). : [Attachment 184011] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 107562: REGRESSION(r140344): Repeated crashes in WKTR
PlatformWebView::viewSupportsOptions().
https://bugs.webkit.org/show_bug.cgi?id=107562

Attachment 184011: Patch
https://bugs.webkit.org/attachment.cgi?id=184011&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184011&action=review


r=me

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:113
> +    bool useTiledDrawing = useTiledDrawingValue ?
WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue)) : false;

This might read better as:

bool useTiledDrawing = useTiledDrawingValue &&
WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue));

What do you think?