[webkit-reviews] review granted: [Bug 105847] [Texmap] Rename TextureMapperShaderManager.* TextureMapperShaderProgram.* : [Attachment 183545] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 105847: [Texmap] Rename TextureMapperShaderManager.*
TextureMapperShaderProgram.*
https://bugs.webkit.org/show_bug.cgi?id=105847

Attachment 183545: Patch
https://bugs.webkit.org/attachment.cgi?id=183545&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183545&action=review


r+ given you add a comment in the changelog:

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:96
> -	   TextureMapperShaderManager textureMapperShaderManager;
> +	   PassRefPtr<TextureMapperShaderProgram>
getShaderProgram(TextureMapperShaderProgram::Options options)
> +	   {
> +	       HashMap<TextureMapperShaderProgram::Options,
RefPtr<TextureMapperShaderProgram> >::iterator it = m_programs.find(options);
> +	       if (it != m_programs.end())
> +		   return it->value;
> +
> +	       RefPtr<TextureMapperShaderProgram> program =
TextureMapperShaderProgram::create(m_context, options);
> +	       m_programs.add(options, program);
> +	       return program;

this looks like more than refactorings, should be described shortly in the
changelog