[webkit-reviews] review denied: [Bug 107531] Web Inspector: do not highlight really long lines in DTE. : [Attachment 183940] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 107531: Web Inspector: do not highlight really long lines in DTE.
https://bugs.webkit.org/show_bug.cgi?id=107531

Attachment 183940: Patch
https://bugs.webkit.org/attachment.cgi?id=183940&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183940&action=review


> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:82
> +	   syntaxTokenHighligh.ranges.sort(comparator);

I thought we don't need sorting anymore.

> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:85
> +	   return syntaxTokenHighligh.ranges.slice(0, lastIndex);

Tokenizer should not produce these at the first place, you are trimming them
too late. And you produce a lot of garbage (in 99% of cases you are cloning
array with no good reason).