[webkit-reviews] review granted: [Bug 107520] [V8] Make an Isolate parameter mandatory in toV8() : [Attachment 183923] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 01:27:37 PST 2013


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 107520: [V8] Make an Isolate parameter mandatory in toV8()
https://bugs.webkit.org/show_bug.cgi?id=107520

Attachment 183923: Patch
https://bugs.webkit.org/attachment.cgi?id=183923&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183923&action=review


> Source/WebKit/chromium/src/WebBlob.cpp:66
> -    return toV8(m_private.get(), v8::Handle<v8::Object>());
> +    return toV8(m_private.get(), v8::Handle<v8::Object>(),
v8::Isolate::GetCurrent());

So sad.  We shouldn't have added this API.


More information about the webkit-reviews mailing list